Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple: MaterialX on Metal #2324

Closed
wants to merge 1 commit into from
Closed

Apple: MaterialX on Metal #2324

wants to merge 1 commit into from

Conversation

slingthor
Copy link
Contributor

Description of Change(s)

  • Enables MaterialX support on Metal. Makes the MaterialX shader generator polymorphic and implements the Metal based functionality.
  • Points to Apple's branched hosted version of MaterialX until official release of MaterialX with Metal
  • Makes sure that on Metal we don't attempt to mipmap textures containing only one pixel.
  • Metal versions 2.2 and earlier don't return upon usage of the discard keyword. Improve discard handling to pass MaterialX unit tests on Metal.

Co-authored by:
Morteza Mostajabodaveh
Jon Creighton

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@slingthor slingthor force-pushed the materialx branch 4 times, most recently from bb8925c to e97eddb Compare March 6, 2023 16:42
@slingthor slingthor mentioned this pull request Mar 6, 2023
Closed
2 tasks
@sunyab
Copy link
Contributor

sunyab commented Mar 14, 2023

Filed as internal issue #USD-8085

@dgovil dgovil mentioned this pull request Apr 10, 2023
Closed
1 task
pixar-oss pushed a commit that referenced this pull request May 19, 2023
@klucknav @pixar-oss
Update to MaterialX v 1.38.7
440257d 
This version update allows for MaterialX support on Metal.

Fixes #2324

(Internal change: 2275891)
@pixar-oss pixar-oss closed this in 5dab6e0 Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slingthor @sunyab