Implement sdf/types.h
internal unit macros with variadics instead of BOOST_PP_LIST
#2590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
By changing
_SDF_UNITS
to a variadic tuple instead of aBOOST_PP_LIST
, several internal macros inpxr/usd/sdf/types.h
can be implemented in terms of existingtf/preprocessorUtilsLite.h
macros. Removing these macros reduces the project's dependency on several boost preprocessor headers (likeboost/preprocessor/list
).This change additionally converts some size macros to
constexpr
variables and C-style arrays tostd::array
. Theconstexpr
changes avoids expanding the macro in multiple places and localizes error messages.std::array
is preferred per the C++ Core Guidelines (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#slcon1-prefer-using-stl-array-or-vector-instead-of-a-c-array) and its usage simplified the migration.Fixes Issue(s)