Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BOOST_PP_SEQ_FOR_EACH_I with constexpr expressions in vt #2831

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

BOOST_PP_SEQ_FOR_EACH_I is used currently to generate compile time indices for all vt value types. This PR generates a TfMetaList from the VT_VALUE_TYPE sequence which is leveraged by a recursive constexpr implementation of GetIndex.

Both changes still require BOOST_PP_SEQ_FOR_EACH, but a forthcoming change will provide a boost free implementation of sequence iteration.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@nvmkuruc nvmkuruc changed the title Replace 'BOOST_PP_SEQ_FOR_EACH_I with constexpr expressions in vt` Replace BOOST_PP_SEQ_FOR_EACH_I with constexpr expressions in vt Nov 27, 2023
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9000

@pixar-oss pixar-oss merged commit b0d709b into PixarAnimationStudios:dev Dec 11, 2023
3 of 5 checks passed
@nvmkuruc nvmkuruc deleted the vttypeindex branch May 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants