Add class to facilitate serialization and validation of code points #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
changed the title
Add class to facilitate serialization and validation of code points
2 tasks
nvmkuruc
force-pushed
the
codepointclass
branch
from
3e210e4
to
12a34d7
Compare
|
Filed as internal issue #USD-9069 |
nvmkuruc
force-pushed
the
codepointclass
branch
from
12a34d7
to
013d65a
Compare
2 tasks
crevilla
reviewed
Dec 18, 2023
| TF_API std::ostream& operator<<(std::ostream&, const TfUtf8CodePoint); | ||
|
|
||
| /// The replacement code point can be used to signal that a code point could | ||
| /// not be decoded and needed to be replaced. |
There was a problem hiding this comment.
It's not a big deal, but I think it would be a little cleaner if this was just
constexpr TfUtf8CodePoint TfUtf8InvalidCodePoint = TfUtf8CodePoint();
since the default constructed TfUtf8CodePoint is the invalid code point getting rid of another hardcoded 0xFFFD
nvmkuruc
force-pushed
the
codepointclass
branch
2 times, most recently
from
9a337ca
to
719933d
Compare
nvmkuruc
force-pushed
the
codepointclass
branch
from
719933d
to
da57a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Depends on (#2855)
#2788 was added to decode UTF-8 strings into code points. This change repurposes the encoding logic from #2120 into a wrapper around a
uint32_t. This wrapper validates on construction and only stores valid UTF-8 code points (ie. surrogates are excluded). Invalid code points are replaced (silently) with theReplacementValue. A stream operator for serialization is provided.The
TF_INVALID_CODE_POINTuint32_thas been replaced with aTfUtf8InvalidCodePointconstexprinstance.To aid testing,
EndAsIterator()has been added to theTfUtf8CodePointViewclass which returns an iterator of the same type asbegin(). While the language (via range based for loops) supports sentinelend()types as of C++17, many STL algorithms don't until C++20. WhileEndAsIterator()this creates redundant copies of thestring_view'send()value, in non-performance critical code, it may be preferable to enable usage of the STL.Fixes Issue(s)