Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup arkit checks #2863

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Dec 11, 2023

Description of Change(s)

This updates the ARKit checker based on what is supported as of WWDC 2023 as per this document:
https://developer.apple.com/documentation/realitykit/validating-usd-files

Though as per that doc, there may be some inter-platform variance that cannot be accounted for in the checker. I've aimed for most permissive in those cases.

Changes include:

  1. Allowing MaterialX shaders within the USD file, denoted by an ND_* prefix.
  2. Support new Prim types, including physics schema, RealityKit components and Preliminary schemas
  3. Removed the ARKitRootLayerChecker and left a deprecation warning for the flag that invoked it
  4. Modified the help docs for usdchecker to specify the year of RealityKit that it is based around. This should help in future iterations to provide more clarity to users as both USD and RealityKit grow.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9074

@pixar-oss pixar-oss merged commit 15ebd4b into PixarAnimationStudios:dev Dec 15, 2023
3 of 5 checks passed
@dgovil dgovil deleted the cleanup-arkit-checks branch December 15, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants