Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of Unlit shaders (Issue 3015) #3016

Closed

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Mar 25, 2024

Description of Change(s)

This PR makes sure that the shadergen checks that the View Position constant is present before it writes code that depends on it.

This fixes cases for shaders like unlit that do not depend on view direction in the rest of their shader code.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9484

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgovil
Copy link
Collaborator Author

dgovil commented Apr 17, 2024

@jesschimein I'll close this one out since #3045 is a more thorough fix that covers the same issue.

@dgovil dgovil closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants