-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utilities for processing ies light files #3061
Conversation
Filed as internal issue #USD-9596 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
These are taken unaltered from blender, v4.1.1 - https://projects.blender.org/blender/blender/src/tag/v4.1.1/intern/cycles/util/ies.h - https://projects.blender.org/blender/blender/src/tag/v4.1.1/intern/cycles/util/ies.cpp These are not yet built / used, but merely introduce the files for use in the codebase later.
Updated the way that these files are vendored, to match how pxrCLI11 works - ie, with a patch file. |
27d41db
to
6c56762
Compare
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR doesn't actually build/use ies.h or ies.cpp yet, as we don't want to slow down / alter the actual build until this code is used - this is to get the legal process started - but look at this pr/ies_build branch for one that will build ies.cpp, to validate it at least compiles: |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
If it helps to get approval from legal - I've since learned that the exact same source code is also hosted in a separate "cycles" repository. The two files in question are the exact same (which I confirmed), and both explicitly say in their headers that they're covered by Apache 2.0:
However, the cycles repo has the additional nice feature that the license listed at the root of the project is the Apache 2.0 one. Relevant Links:
|
Closing in favor of: |
Description of Change(s)
This adds ies.h and ies.cpp, for processing ies light files.
These are originally taken from blender, v4.1.1:
These files are provided by Blender under the Apache 2.0 license. (See the note here about how the "Blender Cycles rendering engine is available as Apache 2.0").
These are not yet built / used, but merely introduce the files for use in the codebase later (ie, as part of a reworked UsdLux update).
The intent is to allow the Pixar legal approval process to get started early.