Apple: Enable Imaging support for Embedded Platforms #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Filed as internal issue #USD-9955 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tcauchois
reviewed
Aug 8, 2024
|
|
|
@davidgyu actually never mind, @ld_kerley caught some issues so I backed out my shader gen changes. I think we need to revisit it on the MaterialX side and then follow up in OpenUSD later. I'll leave the MaterialX build patch in for that reason. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 22, 2024
Closed
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
This PR ports Thor's Imaging work onto the latest USD dev branch. It also includes some patches from Maddy Adams and me to suit the current state of USD and its dependencies. There is a single patch to MaterialX to enable support with USD not using OpenGL builds. Additionally, as requested by Nick Porcino, I have added support for shared memory texture handling on the Mac as well where applicable. I've tested this on macOS with Apple Silicon but do not have Intel macs to test with. I've also tested building this for both iOS and visionOS.
…gic in multiple places
* Note blitCmds.mm is still using the wrong MTLResource type on L.361, which should be MTLBuffer, but that issue is addressed in the following PR: PixarAnimationStudios#3226 Signed-off-by: furby™ <devs@wabi.foundation>
dgovil
force-pushed
the
ios-imaging
branch
2 times, most recently
from
e29fee0 to
38653a8
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… popped up after rebasing on latest dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This PR ports Thor's Imaging work onto the latest USD dev branch and enables imaging for iOS and visionOS. It also includes some patches from Maddy Adams and me to suit the current state of USD and its dependencies.
There is a single patch to MaterialX to enable support with USD not using OpenGL builds.
Additionally, as requested by Nick Porcino, I have added support for shared memory texture handling on the Mac as well where applicable.
I've tested this on macOS with Apple Silicon but do not have Intel macs to test with. I've also tested building this for both iOS and visionOS.
(Jess I believe you'd tracked this as #USD-9841)
Fixes Issue(s)