Add python binding for UsdValidationError
#3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nvmkuruc for vis. |
roggiezhang-nv
force-pushed
the
add_bind_for_usdvalidation_error
branch
from
e4cd5ae
to
51cae57
Compare
|
Filed as internal issue #USD-9995 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roggiezhang-nv
force-pushed
the
add_bind_for_usdvalidation_error
branch
from
51cae57
to
e8831f8
Compare
2 tasks
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roggiezhang-nv
force-pushed
the
add_bind_for_usdvalidation_error
branch
from
e8831f8
to
a048ccd
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tallytalwar
reviewed
Aug 21, 2024
|
|
||
|
|
||
| class TestUsdValidationError(unittest.TestCase): | ||
| def test_create_default_error_site(self): |
There was a problem hiding this comment.
Since I have started syncing this one internally, I am addressing these but as a fyi the naming convention we seem to use here is test_CreateDefaultErrorSite, and _VerifyErrorSiteWithLayer, etc. Refer few examples here: https://github.com/PixarAnimationStudios/OpenUSD/blob/release/pxr/usd/usd/testenv/testUsdStage.py.
There was a problem hiding this comment.
I'll fix them.
There was a problem hiding this comment.
Thanks @roggiezhang-nv. I have already updated these internally for this PR.
There was a problem hiding this comment.
I see. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Add Python binding for
UsdValidationError,UsdValidationErrorSite, andUsdValidationErrorType.It is stacked on #3223, and #3232 for adding Python bindings for validator framework.
Fixes Issue(s)