Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdx: Fixes for 1d luts in HdxColorCorrectionTask #3419

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

pkilgo-blz
Copy link

@pkilgo-blz pkilgo-blz commented Nov 12, 2024

Description of Change(s)

This fixes a couple of issues in HdxColorCorrectionTask for users of 1d luts. We started to notice a TF_VERIFY() failure and a mostly-black/uninitialized viewport in usdview when we upgraded to OCIO 2.2 (VFX CY2023).

ERROR: Usdview encountered an error while rendering.
Error in '<PXR_NS>::HdxColorCorrectionTask::_CreateOpenColorIOShaderCode' at line 562 in file /.../pxr/imaging/hdx/colorCorrectionTask.cpp :
'Failed verification: ' !texInfo.texName.empty() && !texInfo.samplerName.empty() ''
  • 2d106a1 fixes the TF_VERIFY() check.
  • ec769ab initializes the lut values passed to the _TextureSamplerDesc. I was finding float4AdaptedLutValues was only conditionally initialized based on the active HgiFormat fmt.

I realize I've left some of the checklist undone but mostly just checking on interest.

Fixes Issue(s)

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10435

❗ Please make sure that a signed CLA has been submitted!

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants