Allow user to specify boost version #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #154998. |
meshula
commented
Dec 14, 2017
| if Windows(): | ||
| # .0 versions of boost don't end in _0. | ||
| boost_version = "_".join(context.boost.split(".")) | ||
| if boost_version[-2:] == ".0": |
There was a problem hiding this comment.
Typo - this should be == "_0":
|
We'd prefer to keep build_usd.py to a curated set of dependencies for easier testing and validation, especially given the relationships between dependencies like the one between boost and OpenImageIO identified in this PR. This sort of customization (even at an "at-your-own-risk" level) opens us up to more support load; if users want to use different versions they can edit the build script locally, which should make it clear they're in unguarded waters. :) So, I'm going to close this PR out. Thanks! |
|
Makes sense to me, the curated build environment today works for me very well in all the configurations I'm dealing with! |
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…lve/adsk/internal-only/feature/depth-priority OGSMOD-2801: Merge depth priority fix into adsk/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
I'm using boost 1.65.1, and like the convenience of using the standard build script. This modification doesn't change the default behavior, but if boost version is specified on the command line, USD will build with the specified version.
Also handles toolset version for VS2015 and VS2017, because boost 1.65.1 insists on toolset 141 for VS2017.
OpenImageIO 1.7.17 is the minimum compatible with boost 1.65.1
Fixes Issue(s)
build script is hard coded to boost 1.61 and using the 140 toolset with VS2015 and VS2017