-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[usdMaya] added optional euler filter for import #506
Closed
AlexSchwank
wants to merge
1
commit into
PixarAnimationStudios:dev
from
AlexSchwank:pr/mayaEulerFilterImport
Closed
[usdMaya] added optional euler filter for import #506
AlexSchwank
wants to merge
1
commit into
PixarAnimationStudios:dev
from
AlexSchwank:pr/mayaEulerFilterImport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSchwank
changed the title
[usdMaya] added optional euler for import
[usdMaya] added optional euler filter for import
May 23, 2018
Cool, Alex! Not an official review yet, but glancing over several of the
files, there seems to be a recurring pattern that could be factored out
into a utility, that takes (both mutable) previous and current rotations?
…--spiff
On Wed, May 23, 2018 at 7:56 AM, AlexSchwank ***@***.***> wrote:
Description of Change(s)
Added Euler filter to Maya import to fix potential Euler flips for
animated rotations.
The filter is using Maya's MEulerRotation::setToClosestSolution().
Added *eulerFilterMode* option to specify the filter mode (*Auto*
(Default), *On*, *Off*).
This helps with #410
<#410> but obviously
only on the Maya side.
This PR is replacing PR #450
<#450>
------------------------------
You can view, comment on, or merge this pull request online at:
#506
Commit Summary
- [usdMaya] added optional euler for import
File Changes
- *M* third_party/maya/lib/usdMaya/CMakeLists.txt
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-0>
(15)
- *M* third_party/maya/lib/usdMaya/JobArgs.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-1>
(15)
- *M* third_party/maya/lib/usdMaya/JobArgs.h
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-2>
(16)
- *M* third_party/maya/lib/usdMaya/MayaNurbsSurfaceWriter.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-3>
(2)
- *M* third_party/maya/lib/usdMaya/primReaderArgs.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-4>
(11)
- *M* third_party/maya/lib/usdMaya/primReaderArgs.h
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-5>
(7)
- *A* third_party/maya/lib/usdMaya/testenv/UsdImportEulerFilterTest/
UsdImportEulerFilterTest.usda
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-6>
(102)
- *A* third_party/maya/lib/usdMaya/testenv/testUsdImportEulerFilter.py
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-7>
(462)
- *M* third_party/maya/lib/usdMaya/translatorCamera.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-8>
(3)
- *M* third_party/maya/lib/usdMaya/translatorXformable.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-9>
(33)
- *M* third_party/maya/lib/usdMaya/usdExport.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-10>
(12)
- *M* third_party/maya/lib/usdMaya/usdImport.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-11>
(11)
- *M* third_party/maya/lib/usdMaya/usdReadJob.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-12>
(3)
- *M* third_party/maya/lib/usdMaya/usdReadJob_ImportWithProxies.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-13>
(9)
- *M* third_party/maya/lib/usdMaya/usdTranslatorExport.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-14>
(12)
- *M* third_party/maya/lib/usdMaya/usdTranslatorImport.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-15>
(2)
- *M* third_party/maya/lib/usdMaya/usdTranslatorImport.h
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-16>
(3)
- *M* third_party/maya/lib/usdMaya/usdTranslatorImport.mel
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-17>
(8)
- *M* third_party/maya/lib/usdMaya/usdWriteJob.cpp
<https://github.com/PixarAnimationStudios/USD/pull/506/files#diff-18>
(4)
Patch Links:
- https://github.com/PixarAnimationStudios/USD/pull/506.patch
- https://github.com/PixarAnimationStudios/USD/pull/506.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#506>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AF7qaFPxvIfEM7-1BLyV5KG1h3nGeMzRks5t1XiKgaJpZM4UKnx_>
.
|
Filed as internal issue #161151. |
Closing this out as development for the Maya USD plugins moved to https://github.com/Autodesk/maya-usd. Please resubmit in that repo for future development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Added Euler filter to Maya import to fix potential Euler flips for animated rotations.
The filter is using Maya's
MEulerRotation::setToClosestSolution()
.Added eulerFilterMode option to specify the filter mode (Auto (Default), On, Off).
This helps with #410 but obviously only on the Maya side.
This PR is replacing PR #450