Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::isnan instead of isnan in rgb and rgba.h #55

Closed
wants to merge 1 commit into from
Closed

Conversation

doctormo
Copy link

Fix issue #52 for popey. Use std::isnan instead of just isnan, std was already used in pxr/usd/lib/usd/timeCode.h so it should be fine.

@sunyab
Copy link
Contributor

sunyab commented Oct 28, 2016

Hi @doctormo, just to update you on this, our current plan is to simply remove gf/rgb.h and rgba.h from the distribution since they're not being used. I'll leave this open until that actually goes through.

Also, just wanted to ask you to fill out the CLA per the instructions below should you wind up contributing more changes in the future: http://graphics.pixar.com/usd/docs/Contributing-to-USD.html

Thanks!

@doctormo
Copy link
Author

Good to hear. Thanks for the update. No need to merge or anything.

We do a Public Domain declaration, since CLAs cause more paperwork and messing about than a normal multi-stakeholder open source project. So probably no large contributions, but the odd patch is easy enough to PD and hopefully is enough for your lawyers.

@sunyab
Copy link
Contributor

sunyab commented Nov 14, 2016

Commit 57d4d15 was pushed last week, closing this out per my comment above. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants