Alembic support #56
Merged
Alembic support #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
September 12, 2016 07:46
…meaning that the fileName attribute did not manifest itself as a file.
…ver::Ar_DefaultResolver() only. This means either slash type can be passed and relative paths will be fixed up correctly.
…ariables in a string.
… constructor stuff to work.
meshula
reviewed
Sep 21, 2016
| VERSION_VAR | ||
| MAYA_API_VERSION | ||
| ) | ||
| if (${PXR_MAYA_API_ONLY} AND NOT ${PXR_MAYA_API_ONLY}) |
There was a problem hiding this comment.
Is this test for ${A} AND NOT ${A} a cmake-ism or a typo?
There was a problem hiding this comment.
As I understand its the difference between
#define A
and
#define A 1
So it tests the variable exists and its not been set to true.
There was a problem hiding this comment.
Ah, gotcha :) So much cmake to learn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now build and run the usdAbc plugin.