Add a check for a valid UsdPrim when looping over affectedPrims in _RefreshObject #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…im is deleted from the stage, and a collection which points directly to that prim is updated. This would crash while processing the change to the collection, as it would access the underlying UsdPrim from the index's PrimInfo map without checking that it is still valid. To get around this, test the validity of the UsdPrims that show up in the affectedPrims list.
|
Filed as internal issue #USD-4893. |
pixar-oss
added a commit
that referenced
this pull request
Nov 21, 2018
…rash Add a check for a valid UsdPrim when looping over affectedPrims in _RefreshObject (Internal change: 1915148)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…s#685) ### Description of Change(s) Move genericText structure to USD. ### Fixes Issue(s) - <!-- Please follow the Contributing and Building guidelines to run tests against your change. Place an X in the box if tests are run and are all tests passing. --> - [ ] I have verified that all unit tests pass with the proposed changes <!-- Place an X in the box if you have submitted a signed Contributor License Agreement. A signed CLA must be received before pull requests can be merged. For instructions, see: http://openusd.org/release/contributing_to_usd.html --> - [ ] I have submitted a signed Contributor License Agreement (cherry picked from commit e13fb5df34a57929f04bf982d14f29091ca1755c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a crash when processing a stage update in hydra in which a prim is
deleted from the stage, and a collection which points directly to that prim
is updated. This would crash while processing the change to the collection,
as it would access the underlying UsdPrim from the index's PrimInfo map
without checking that it is still valid. To get around this, test the
validity of the UsdPrims that show up in the affectedPrims list.
Fixes Issue(s)
684