usdview picks prototype meshes instead of top-level instancers in v20.05

[asluk]

With the rewrite of instance index to prim path queries in 82e343c , it looks like picking point instancers in instance or prim picking mode ends up selecting the prototype meshes instead of the overarching point instancer prim. For example, this is the output from the ptinst city with USDIMAGING_SELECTION debug enabled:

GetScenePrimPath: proto = /MediterraneanHills/Buildings.proto1_mesh_0_id0
GetScenePrimPath(/MediterraneanHills/Buildings.proto1_mesh_0_id0, 1840) = /MediterraneanHills/Buildings/Prototypes/prototype_1/mesh_0
Prim selection: /MediterraneanHills/Buildings/Prototypes/prototype_1/mesh_0
- affected hydra prim: /MediterraneanHills/Buildings.proto1_mesh_0_id0
PopulateSelection: proto = /MediterraneanHills/Buildings.proto1_mesh_0_id0 pi = /MediterraneanHills/Buildings
PopulateSelection: (prim) /MediterraneanHills/Buildings.proto1_mesh_0_id0 []

It looks like it does know that that "pi" is /MediterraneanHills/Buildings, but the actual returned path and selection content is the prototype mesh. In prim picking mode, all instances for the selected prototype get highlighted in the viewport.

This breaks workflows where a user wants to pick a point instancer in the viewport and toggle vis/invis, for example, at the prim level.

Ideally, usdview would pick the top-level instancer in this case, and UsdImaging would expose an API which, given an rprim and instance index, return the path to that top-level instancer.

Thank you!

[asluk]

See https://groups.google.com/d/msg/usd-interest/-CF8BCGVdu4/3xOHu9kCBAAJ for more context

[jtran56]

Filed as internal issue #USD-6054.

[asluk]

I've verified that I can pick the top-level instancer in the City_set again with v20.08-rc1 usdview -- thanks!

However, I can't pick the top-level instances in this "point instancers inside native instances" example -
ni_pi.zip , whereas I can in v19.11 usdview.

[asluk]

Thanks for the fix-- I implemented something similar to get this working in our app as well.

It feels like something is going awry with the intersection test itself though-- most of the time, picking on geometry in the previously attached native/ptinst nesting doesn't get a hit. Here is some usdviewq.StageView.pick() debug output from picking around the same area several times in v20.08-rc3 until it hits, where as in v19.11, it would always get a hit.

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(6.95232936630046e-310, 0.0, 0.0), Sdf.Path.emptyPath, 89096624, Sdf.Path.emptyPath, -1)

Pick results = (Gf.Vec3d(95.10247802734375, 401.83282470703125, 19.532217025756836), Sdf.Path('/World/sphereInstancer/Instancer/Dummy/sphere'), 10, Sdf.Path('/World/sphereInstancer/Instancer'), 10)

[asluk]

I don't necessarily think that the remaining pick-miss issue needs to hold up the release from our perspective, as it works properly in our app, but I'm not sure what's going awry in usdview, at least on Windows.

[spiffmon]

We noticed that issue also, Aaron, while looking into this. We have filed it and are investigating, though not holding up 20.08 for it. Thanks! —spiff

On Fri, Jul 17, 2020 at 2:20 AM Aaron Luk ***@***.***> wrote: I don't necessarily think that the remaining pick-miss issue needs to hold up the release from our perspective, as it works properly in our app, but I'm not sure what's going awry in usdview, at least on Windows. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPOU2AZ6X77ZBJTVUXRT33R4AJWVANCNFSM4M2UBKYQ> .

-- --spiffiPhone