Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material bindings are not honored on scenegraph instances inside of point instances #1449

Closed
asluk opened this issue Feb 11, 2021 · 1 comment

Comments

@asluk
Copy link
Collaborator

asluk commented Feb 11, 2021

Description of Issue

Materials bound to point instancer prototypes are not honored by scenegraph instances within those protoypes.

Steps to Reproduce

grass_scatter0.zip

  1. Unzip the attached archive.
  2. Open grass_scatter0/layout/grass_scatter_layout.usda in usdview
  3. The spheres all draw with no materials.
  4. Select /grass_plain/tree_instancer/Prototypes/tree_1/tree_1_geo/tree_1_leaves/obj_0 in the Browser
  5. in the interpreter, usdviewApi.prim.SetInstanceable(False)
  6. The spheres will turn blue, now honoring the bound UsdPreviewSurface

System Information (OS, Hardware)

Windows

Package Versions

current dev branch

Build Flags

python build_scripts\build_usd.py _install

@jilliene
Copy link

Filed as internal issue #USD-6570

marktucker added a commit to sideeffects/USD that referenced this issue Sep 19, 2021
The fix for PixarAnimationStudios#1449 looks like it broke material bindings in the case where
a point instancer prototype was marked as instanceable, but the material
was bound inside the prototype (on an instance proxy). The bound material
was being expressed with the instance proxy path instead of the prototype
path, which is how the material is actually identified in hydra. So now
the fix for PixarAnimationStudios#1449 is only applied to the instanceable prim, not the
contained instance proxy prims.

Fixes PixarAnimationStudios#1626
marktucker added a commit to sideeffects/USD that referenced this issue Sep 19, 2021
The fix for PixarAnimationStudios#1449 looks like it broke material bindings in the case where
a point instancer prototype was marked as instanceable, but the material
was bound inside the prototype (on an instance proxy). The bound material
was being expressed with the instance proxy path instead of the prototype
path, which is how the material is actually identified in hydra. So now
the fix for PixarAnimationStudios#1449 is only applied to the instanceable prim, not the
contained instance proxy prims.

Fixes PixarAnimationStudios#1626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants