Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HdPrman doesn’t respect scene up for dome light orientation #938

Closed
radon199 opened this issue Aug 15, 2019 · 1 comment
Closed

HdPrman doesn’t respect scene up for dome light orientation #938

radon199 opened this issue Aug 15, 2019 · 1 comment

Comments

@radon199
Copy link

Description of Issue

As per this post on the forums : https://groups.google.com/d/msg/usd-interest/w2TLrpVVZvQ/wQuUOqQvCQAJ

HdPrman seems to always orient dome lights on the Z- axis regardless of if the stage is oriented on Z up or Y up. Even when the scene is set to Z up the dome draws as upside down vs how Usdview orients the camera.

Steps to Reproduce

  1. Create a scene with a dome light and texture and stage metadata set to Y up.
  2. Render with HdPrman and check dome orientation via the texture.

System Information (OS, Hardware)

CentOs7

Package Versions

Usd19.07

Build Flags
@jilliene
Copy link

Filed as internal issue #USD-5495

pixar-oss pushed a commit that referenced this issue Sep 20, 2019
@sarahsunnysideup @pixar-oss
Light schema and orientation updates
53ebfea 
This change defines the orientation of textured dome and rect lights.

For #938

(Internal change: 2002992)
pixar-oss pushed a commit that referenced this issue Sep 20, 2019
@sarahsunnysideup @pixar-oss
Light schema and orientation updates
7c427a1 
Update hdPrman to correctly transform lights.  The previous work in change 1970330 didn't take into account texture orientation.
This change matches the newly defined USD spec, which matches the OpenEXR environment map conventions.
Currently only the dome light is special-cased with all other light types using the same orient transform.  If we add support for PxrEnvDayLight, that will need to be special-cased as well.

For #938

(Internal change: 2002994)
This was referenced Aug 20, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radon199 @jilliene