Clarify mesh subdivision options in physics documentation #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding subdivision to a mesh may visibly impact physics collider generation and is easy to miss. Add a short note to make potential implementors aware that this could be a source of discrepancy between graphical and physics representation of a mesh.
spiffmon
reviewed
Jul 14, 2022
pxr/usd/usdPhysics/overview.dox
Outdated
| @@ -379,6 +379,12 @@ a bounding sphere. If an implementation does not support a particular kind of | |||
| approximation, it is recommended that it falls back to the most similar | |||
| supported option. | |||
|
|
|||
| Note that use of the subdivision attribute (\ref | |||
| UsdGeomMesh::GetSubdivisionSchemeAttr()) can cause features such as sharp | |||
| corners to be removed from the graphical representation. In order to ensure the | |||
There was a problem hiding this comment.
Suggest:
“corners and edges to be…”
There was a problem hiding this comment.
Good shout; thanks. Reworded that part.
|
Filed as internal issue #USD-7491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Add a short note to physics documentation for an easy-to-overlook property which might affect an implementation.