Merge pull request #146 from PixelgenTechnologies/feature/exe-1723-a-…

…pixels-per-b-pixel-typo fix a bug where `a_pixels_per_b_pixel` stats where equal to the`b_pixels_per_a_pixel` stats
PixelgenTechnologies · May 27, 2024 · 7c69253 · 7c69253
2 parents 6c1b0c9 + 4a65534
commit 7c69253
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [UNRELEASED] - 2024-??-??
+
+### Fixed
+
+* Fix a bug where `a_pixels_per_b_pixel` summary statistics where equal to the `b_pixels_per_a_pixel` statistics.
+
 ## [0.17.1] - 2024-05-27
 
 ### Fixed

diff --git a/src/pixelator/graph/utils.py b/src/pixelator/graph/utils.py
@@ -101,8 +101,8 @@ def components_metrics(edgelist: pd.DataFrame) -> pd.DataFrame:
         median_b_pixels_per_a_pixel = b_pixels_per_a_pixel_series.median()
 
         a_pixels_per_b_pixel = group_df.groupby("upib", observed=True)["upia"].nunique()
-        mean_a_pixels_per_b_pixel = b_pixels_per_a_pixel_series.mean()
-        median_a_pixels_per_b_pixel = b_pixels_per_a_pixel_series.median()
+        mean_a_pixels_per_b_pixel = a_pixels_per_b_pixel.mean()
+        median_a_pixels_per_b_pixel = a_pixels_per_b_pixel.median()
 
         # Same reasoning as above
         molecule_count_per_a_pixel_series = group_df.groupby("upia", observed=True)[

diff --git a/...s_flow_summaru/molecules_flow_summary.csv → ...s_flow_summary/molecules_flow_summary.csv b/...s_flow_summaru/molecules_flow_summary.csv → ...s_flow_summary/molecules_flow_summary.csv
diff --git a/tests/report/test_reporting.py b/tests/report/test_reporting.py
@@ -55,7 +55,7 @@ def test_reporting_reads_flow_summary(
     snapshot.assert_match(reads_flow.to_csv(), "reads_flow_summary.csv")
 
 
-def test_reporting_molecules_flow_summaru(
+def test_reporting_molecules_flow_summary(
     pixelator_workdir, all_stages_all_reports_and_meta, snapshot
 ):
     reporting = PixelatorReporting(pixelator_workdir)