Feature/exe 1884 make community detection deterministic #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #176 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 121 121
Lines 6795 6795
=======================================
Hits 5557 5557
Misses 1238 1238 ☔ View full report in Codecov by Sentry. |
ptajvar
force-pushed
the
feature/exe-1884-make-community-detection-deterministic
branch
from
51b4d5b to
0c964e5
Compare
johandahlberg
approved these changes
Aug 30, 2024
ambarrio
approved these changes
Aug 30, 2024
| @@ -221,7 +221,7 @@ def annotate_components( | |||
| # components clustering | |||
| if adata.n_obs > MINIMUM_NBR_OF_CELLS_FOR_ANNOTATION: | |||
| # perform the unsupervised clustering | |||
| cluster_components(adata=adata, inplace=True) | |||
| cluster_components(adata=adata, inplace=True, random_seed=1) | |||
There was a problem hiding this comment.
why the different random_seed here and in _networkx?
| @@ -305,6 +305,7 @@ def community_leiden( | |||
| graph, | |||
| use_modularity=True, | |||
| randomness=beta, | |||
| random_seed=42, | |||
There was a problem hiding this comment.
Should we use the same see everywhere? i.e. 1477 :)
|
Superseded by PR 188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a random seed for leiden algorithm so that component IDs remain constant through multiple runs of pipeline.
Fixes: #EXE-1884
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
PR checklist: