fix: unusually large multi-target polarity plot #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unusually large plot is created when selecting multiple targets in plot_polarity_diff_volcano. The bug is caused by not setting the index for target_differential_polarity to be the marker, resulting in index mismatch when calculating the mean polarity for markers in the target.
In addition the title for differential polarity/colocalization is now changed to "Differential polarity/colocalization between {target} and {reference}" rather than "between {reference} and {target}" to indicate that a positive value indicates higher value in target.
Fixes: EXE-2009
Type of change
How Has This Been Tested?
Existing unit tests and the tutorial code.
PR checklist: