Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "depth" column to the discarded_edgelist #195

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

ptajvar
Copy link
Contributor

@ptajvar ptajvar commented Oct 22, 2024

This PR adds a "depth" column to the discarded edgelist as it enables easier downstream analysis to understand the multiplet recovery process.

The recovered_components file will also be removed as an output of the GRAPH step. The recovered_components file stores the refinement history and is no longer needed as it can be easily recovered from discarded edgelist. We can backtrack to a given refinement depth by bringing in the edges that are removed after that depth. If we merge all of the edges from discarded_edgelist to edgelist we will recover the COLLAPSE output.

Fixes: EXE-2046

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Unit tests, and tried on a V2 sample.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

@ptajvar ptajvar force-pushed the feature/exe-2046-add-depth-info-to-discarded-edgelist branch from d080994 to 436867f Compare October 22, 2024 12:18
@ptajvar ptajvar requested review from ludvigla and ambarrio October 22, 2024 12:49
@ptajvar ptajvar marked this pull request as ready for review October 22, 2024 12:49
Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ludvigla ludvigla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ptajvar ptajvar merged commit ffa1b8d into dev Oct 22, 2024
14 checks passed
@ptajvar ptajvar deleted the feature/exe-2046-add-depth-info-to-discarded-edgelist branch October 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants