Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cli start-up speed #196

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

johandahlberg
Copy link
Contributor

Description

Since graspologic takes a long time to import we have had those imports done dynamically as they are needed rather than at the module level. This speeds up cli start up times considerably.

I also cleaned out some unused imports.

Fixes: N/A

Type of change

Only changes when things are imported.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce it when relevant.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated poetry.lock, and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

@johandahlberg johandahlberg requested a review from ptajvar October 28, 2024 15:09
@johandahlberg johandahlberg merged commit d9e4022 into dev Oct 28, 2024
14 checks passed
@johandahlberg johandahlberg deleted the chore/dynamic-import-of-graspologic branch October 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants