Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/exe 2065 set hard cutoff on min size #201

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Feature/exe 2065 set hard cutoff on min size #201

merged 2 commits into from
Dec 10, 2024

Conversation

johandahlberg
Copy link
Contributor

Description

Set a hard cutoff of 300 edges on the minimum component size when using --dynamic-filter min or --dynamic-filter both in annotate.

Depends on merging #200.

Fixes: exe-2065

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests and by manually running pixelator.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If a new tool or package is included, I have updated poetry.lock, and cited it properly
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

@johandahlberg johandahlberg force-pushed the feature/exe-2065-set-hard-cutoff-for-min-size branch from 245fd2f to 3845df2 Compare December 10, 2024 14:13
@johandahlberg johandahlberg changed the title Feature/exe 2065 set hard cutoff for min size Feature/exe 2065 set hard cutoff on min size Dec 10, 2024
ambarrio
ambarrio approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I approve with just a question that can be answered.

tests/annotate/test_cell_calling.py Show resolved Hide resolved
@ambarrio
Copy link
Contributor

Ok, let's go! 🚀

@johandahlberg johandahlberg merged commit 45a8cdd into dev Dec 10, 2024
14 checks passed
@johandahlberg johandahlberg deleted the feature/exe-2065-set-hard-cutoff-for-min-size branch December 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarrio ambarrio ambarrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johandahlberg @ambarrio