Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exe 2084 bug in local g #205

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Exe 2084 bug in local g #205

merged 4 commits into from
Dec 20, 2024

Conversation

johandahlberg
Copy link
Contributor

Description

In some scenarios local g will return scrambled results due to inconsistent node ordering. This fixes that.

Fixes: exe-2084

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests, and by manual tests on failing components.

PR checklist:

  • This comment contains a description of changes (with reason).
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and documentation and corrected any misspellings
  • I have documented any significant changes to the code in CHANGELOG.md

Copy link
Contributor

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really good 👀 to catch up 🐛

@johandahlberg johandahlberg merged commit 29942a5 into dev Dec 20, 2024
14 checks passed
@johandahlberg johandahlberg deleted the exe-2084-bug-in-local-g branch December 20, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants