Feature/dapp #79
Merged
Feature/dapp #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove env vars that are not actually used. Add a mint pizza sequence diagram. update docs, etc
update fallback function
they take a while
add a deployment to mumbai
when ethers added official support, they chose maticmum as the name. see here: ethers-io/ethers.js#1546 (comment)
remove the logic to purchase a pizza. it now just redirects to the box contract (for api consistency). Also use the box id as the token id for the pizza for now.
add the job as a string and use assembly to load it into bytes32. note this is dangerous.
use openzep's _msgSender() in some places
update packages
The IPFS hashes are too big when coming in from the chainlink oracle to fit in bytes32 so they get converted from base58 into a uint and the multihash bytes are stripped off, then recombined when reading out the hash when calling tokenURI.
add missing function parameters add a few missing checks. change the data type of the address to a uint
…to align the semantics of the contracts.
bleeckerj
reviewed
Oct 25, 2021
bleeckerj
reviewed
Oct 25, 2021
AddressXception
requested review from
CryptoSpaces,
antron3000,
johhonn,
snackman and
strawberry-wtf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a dapp and hook it up to webflow
currently only supporting metamask
'connects to both the box and the pizza contract and handles event state changes. removes some unnecessary function passthroughs in the pizza contract (they were just causing problems). available right now on the beta site hooked up to rinkeby (ask me for a link)