Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue password in Appeals API service, and remove uk south private endpoint #99

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

andylangridge
Copy link
Contributor

@andylangridge andylangridge commented Jun 6, 2022

  • Fixes incorrect Servicebus password being passed to the Appeals API
  • Removes CosmosDB private endpoint in UK South
  • Fixes terraform validate pre-commit hook. This was broken due to a bug in Terraform - configuration_aliases in child module terraform validate fails: Provider configuration not present hashicorp/terraform#28490. Have worked around it for now by just running terraform validate in the top level modules (stacks). Have done this by adding a script to copy the providers into the stacks folder (something terragrunt does for us in the CI pipeline), and some local hooks to run the script before and after validate.

@andylangridge andylangridge merged commit 038e8e2 into main Jun 8, 2022
@andylangridge andylangridge deleted the fix/servicebus-key branch June 8, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants