hotfix: bind hmrHost with the builder socket

PlasmoHQ · Sep 5, 2023 · fa6045e · fa6045e
1 parent d975d46
commit fa6045e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/cli/create-plasmo/package.json b/cli/create-plasmo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "create-plasmo",
-  "version": "0.82.3",
+  "version": "0.82.4",
   "description": "Create Plasmo Framework Browser Extension",
   "main": "dist/index.js",
   "bin": "bin/index.mjs",

diff --git a/cli/plasmo/package.json b/cli/plasmo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plasmo",
-  "version": "0.82.3",
+  "version": "0.82.4",
   "description": "The Plasmo Framework CLI",
   "publishConfig": {
     "types": "dist/type.d.ts"

diff --git a/cli/plasmo/src/commands/dev.ts b/cli/plasmo/src/commands/dev.ts
@@ -31,9 +31,11 @@ async function dev() {
     getPort({ port: parseInt(rawServePort) }),
     getPort({ port: parseInt(rawHmrPort) })
   ])
-  const buildWatcher = getBuildSocket(hmrPort)
 
-  vLog(`Starting dev server on ${serveHost}:${servePort}, HMR on ${hmrHost}:${hmrPort}...`)
+  const buildWatcher = getBuildSocket(hmrHost, hmrPort)
+  vLog(
+    `Starting dev server on ${serveHost}:${servePort}, HMR on ${hmrHost}:${hmrPort}...`
+  )
 
   const bundleConfig = getBundleConfig()
 

diff --git a/packages/framework-shared/build-socket/index.ts b/packages/framework-shared/build-socket/index.ts
@@ -4,8 +4,11 @@ import { BuildSocketEvent } from "./event"
 
 export { BuildSocketEvent }
 
-const createBuildSocket = (hmrPort: number) => {
-  const wss = new WebSocketServer({ port: hmrPort + 1 })
+const createBuildSocket = (hmrHost: string, hmrPort: number) => {
+  const wss = new WebSocketServer({
+    host: hmrHost,
+    port: hmrPort + 1
+  })
 
   const broadcast = (type: BuildSocketEvent) => {
     for (const client of wss.clients) {
@@ -22,7 +25,7 @@ const createBuildSocket = (hmrPort: number) => {
 
 let _buildSocket: Awaited<ReturnType<typeof createBuildSocket>>
 
-export const getBuildSocket = (hmrPort?: number) => {
+export const getBuildSocket = (hmrHost = "localhost", hmrPort?: number) => {
   if (process.env.NODE_ENV === "production") {
     return null
   }
@@ -35,7 +38,7 @@ export const getBuildSocket = (hmrPort?: number) => {
     throw new Error("HMR port is not provided")
   }
 
-  _buildSocket = createBuildSocket(hmrPort)
+  _buildSocket = createBuildSocket(hmrHost, hmrPort)
   return _buildSocket
 }