Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed support of inline anchor insert position #907

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dvvolynkin
Copy link
Contributor

Details

This PR fixes the support for specifying the anchor insert position.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

Discord: dvvolynkin

@dvvolynkin
Copy link
Contributor Author

dvvolynkin commented Mar 6, 2024

Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh this is super cool! LGTM 👍

Signed-off-by: L <6723574+louisgv@users.noreply.github.com>
Comment on lines -197 to -198
inlineAnchor instanceof Element &&
!mountedInlineAnchorSet.has(inlineAnchor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems like Prettier is not doing its job here :-?

@louisgv louisgv added this pull request to the merge queue Mar 7, 2024
Merged via the queue into PlasmoHQ:main with commit 9b51f43 Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants