Implement a new View Changesets window with filtering capabilities #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
2 times, most recently
from
dce2d8e
to
403ec56
Compare
…ch with one Revision for Diffing (like for Files and ShelvedFiles in FPlasticSourceControlChangelist)
…rd output, and update ParseBranchesResults() accordingly Minor cleanup in preparation of getting the Changesets the same way
…e tooltip on the "View Locks" window The conversion to short name should be only done at display time where space matters, eg in the Content Browser context tooltip
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
2 times, most recently
from
d208a07
to
b72eeef
Compare
…d then ParseChangesetsResults()
It's not strictly related to the task but I am using this Branches Widget code to create the new Changesets View and realized it was missing this feature
…he View Branches & View Locks windows
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
from
b72eeef
to
cf51bd2
Compare
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
from
cf51bd2
to
ff60c77
Compare
Rationale: "log" is way to expensive, fetching all files, and cannot be limited to a certain number of changesets to work around the issue. This will require lazy loading the list of files on selecting changesets instead, but that's for another task.
…ngesets" operation Leverages the existing parser GetChangesetFromWorkspaceStatus()
…ranchName field from the underlying command instead
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
from
ff60c77
to
3ad9456
Compare
…e collumns to better fit their content
SRombautsU
force-pushed
the
1005073-view-changesets-window
branch
from
963009e
to
9da0a94
Compare
juliomaqueda
requested changes
Apr 16, 2024
Source/PlasticSourceControl/Private/PlasticSourceControlUtils.cpp
Outdated
Show resolved
Hide resolved
… for the date format
juliomaqueda
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new dockable window,
We need to gather, parse and assemble the underlying data using "cm find changesets" (or cm log?) to list Changesets and then Files in changesets, and reference their Revisions for diffing.
We want a new window similar to the "View Branches" or the "View Locks", but it will evolve with some more advanced widgets to be able to also list the files in each changeset =>more like the "View Changes" window