Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update DevLoadingView to Support iPhone X
Summary: The current implementation of DevLoadingView for iPhone currently gives a static height of `22` and does not take into account iPhoneX screen dimensions. Devices: All iPhone devices currently available with Xcode v9.2 SDK: 8.1, 9, 10, 11 Validate resize only occurs on iPhone X devices and others remain consistent. Before: ![feb-10-2018 12-30-20](https://user-images.githubusercontent.com/1743953/36065313-7b41f2ea-0e5e-11e8-87f2-928e26536077.gif) After: ![feb-10-2018 12-28-15](https://user-images.githubusercontent.com/1743953/36065317-848e4f7e-0e5e-11e8-8aab-70cb5db32f31.gif) [GENERAL][ENHANCEMENT][{React}] - Improvements to DevLoadingView for iPhone X Closes facebook#17936 Differential Revision: D6962962 Pulled By: shergin fbshipit-source-id: e11d9386544fe19a9195e22a03e12f64e934cad7
- Loading branch information
53e8df0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use magical numbers, the correct implementation would be to use
safeAreaInsets
like I did here: https://github.com/cooperka/react-native-snackbar/pull/65/files