Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/api_post_synthese #2354

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat/api_post_synthese #2354

wants to merge 1 commit into from

Conversation

joelclems
Copy link
Contributor

No description provided.

@joelclems joelclems force-pushed the feat/api_post_synthese2 branch 4 times, most recently from 87963e1 to 2c6cb69 Compare February 21, 2023 09:25
@joelclems joelclems force-pushed the feat/api_post_synthese2 branch from 2c6cb69 to d02b1a7 Compare February 21, 2023 09:26
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 68.36% // Head: 68.46% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (43ce175) compared to base (a67ffc7).
Patch coverage: 92.05% of modified lines in pull request are covered.

❗ Current head 43ce175 differs from pull request most recent head d02b1a7. Consider uploading reports for the commit d02b1a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2354      +/-   ##
===========================================
+ Coverage    68.36%   68.46%   +0.10%     
===========================================
  Files           82       84       +2     
  Lines         7289     7354      +65     
===========================================
+ Hits          4983     5035      +52     
- Misses        2306     2319      +13     
Flag Coverage Δ
pytest 68.46% <92.05%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/app.py 76.78% <ø> (-6.25%) ⬇️
...end/geonature/core/gn_synthese/exchanges/routes.py 85.39% <85.39%> (ø)
...geonature/core/gn_synthese/exchanges/repository.py 96.00% <96.00%> (ø)
...ckend/geonature/core/gn_synthese/exchanges/util.py 97.33% <97.33%> (ø)
backend/geonature/core/admin/admin.py 93.84% <0.00%> (ø)
backend/geonature/core/ref_geo/routes.py
backend/geonature/utils/config_schema.py 92.36% <0.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bouttier
Copy link
Contributor

bouttier commented Mar 1, 2023

Je pense qu’il serait pas mal d’ouvrir une issue sur ce sujet, avec les objectifs, les cas d’usage, les specs de l’API, ses limitations …

@camillemonchicourt
Copy link
Member

Y a un ticket sur le sujet ici - #736

Mais certainement a rediscuter pour que cette API post serve de référence, soit stable et se nourrisse aussi du refactoring récent d'Occhab.

@camillemonchicourt
Copy link
Member

Et il y avait déjà une PR en draft similaire avec quelques commentaires - #1793
Cette PR la remplace ?

@joelclems
Copy link
Contributor Author

Oui cette PR la remplace

@bouttier bouttier added this to the 2.13 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants