-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Update button loading prop usage #125
Conversation
<Button loading>Primary Loading</Button> | ||
<Button loading buttonType="secondary"> | ||
<Button isLoading>Primary Loading</Button> | ||
<Button isLoading buttonType="secondary"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested that the basic loading
functionality worked by changing these locally to be loading
and seeing no regressions.
icon, | ||
textColor, | ||
...rest | ||
} = this.props; | ||
|
||
const loadingVal = loading === undefined ? isLoading : loading; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core of the backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good. I notice we merged some other PR without a Radiance release, could you check all the merged commits after the last release, for example Ben merged a new font constant yesterday we need to include that in the release notes. Or let me know I can process a release as well
What & Why
loading
attribute to the DOM by renaming all usage in<Button />
and<RoundButton />
toisLoading
.loading
Other