-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emotion dependencies #124
Conversation
…nent styling, rearrange decorators
sweet, yeah we should deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Currently investigating why the styles that I was seeing locally are: 1. Not on review app, but, more importantly, 2. Not appearing locally either 😅 |
I removed |
What & Why
emotion
is the framework-agnostic version of the library. TheGlobal
component in@emotion/core
achieves the same functionality asinjectGlobal
, so I've replaced that functionality and removedemotion
as a dependency.Other
We log the following warning in development (from our tests for
button
androundButton
:I may or may not create a follow-up PR shortly to update this, depending on how big the diff would be in our other repos.