-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swp 714 project setup #2
Feature/swp 714 project setup #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come using yarn over npm ?
tsconfig-for-declaration.json
Outdated
"emitDeclarationOnly": true, | ||
"isolatedModules": false, | ||
"declaration": true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting an error (can't remember the specific warning) but found this as a fix microsoft/TypeScript#29490 (comment)
The issue was having emitDeclaration
and isolatedModules
in the same tsconfig file. I have just built it again and seems fine. I will remove this and if it occurs again I can discuss the specific error with you then 👍
tsconfig.production.json
Outdated
"sourceMap": true, | ||
"inlineSources": true, | ||
"sourceRoot": "/" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this file used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad copy, will remove
I was getting this issue on local and Travis, using Yarn seemed to fix it... https://travis-ci.com/Pod-Point/react-dom-components/builds/129841126. However, very annoyingly, it seems to be building in my local version now. |
I am breaking up the first PR (#1) as it was too large. This is the setup of the project, example env, packages, travis and react-create-app setup