small fix: wrong scale of initial cloud viewer (PCLVisualizer) #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
added a commit
that referenced
this pull request
Jan 29, 2015
small fix: wrong scale of initial cloud viewer (PCLVisualizer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial windows size of the cloud viewer without a user given parameter should be half of the screen size, but it is 1/4 of the screen size (test: e.g. 'pcl_pcd_grabber_viewer'). Unfortunatly vtk's 'GetScreenSize' function returns the window size as pointer instead of the screen size. So the call of 'win_->SetSize' reduces the window size again to one half, thus a total of 1/4. The variable should be decoupled on pcl side and not carried as pointer.