Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PPFRegistration #5767

Merged
merged 6 commits into from
Aug 24, 2023

Commits on Jul 20, 2023

  1. Improve PPFRegistration

    - add function getBestPoseCandidates to have access to all pose candidates, not just the one with the most votes
    - use ceil instead of floor, otherwise the accumulator_array can be too small in some cases
    - do not only use the single highest peak from accumulator array, but use more peaks if they have similarly many votes as the maximum
    - while pose clustering, make sure that a pose is added to the closest cluster, not simply to the first cluster below the clustering threshold (if more than one clusters are possible)
    - use a better threshold-based filtering of candidate poses, instead of always using the 3 poses with the most votes
    - re-activate and improve test for PPFRegistration
    mvieth committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    136d1fa View commit details
    Browse the repository at this point in the history
  2. Make clang-tidy happy

    mvieth committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    37fd985 View commit details
    Browse the repository at this point in the history
  3. Make clang-format happy

    mvieth committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3a60d23 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Add more const

    mvieth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    91a9ea4 View commit details
    Browse the repository at this point in the history
  2. clang-format

    mvieth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3f03cf0 View commit details
    Browse the repository at this point in the history
  3. Update ppf_registration.h

    mvieth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    662640c View commit details
    Browse the repository at this point in the history