Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI That displays downloaded map #115

Open
NPCtom opened this issue Jan 5, 2019 · 5 comments
Open

GUI That displays downloaded map #115

NPCtom opened this issue Jan 5, 2019 · 5 comments

Comments

@NPCtom
Copy link

NPCtom commented Jan 5, 2019

Is there any update on when the GUI displaying what you have downloaded will be released? I think something similar to Xaero's World Map would be quite cool where you can move through it and see the different chunks. For now I have been using Minecraft Overviewer which is a very tedious process.

@uyjulian
Copy link
Collaborator

uyjulian commented Jan 5, 2019

Would adding a button to open a third-party program such as MCEdit or Minecraft Overviewer be okay?

@Pokechu22
Copy link
Owner

I don't have any current time scale, other than "after the next update". My current goals for the next release are still the fixes related to maps and backups, and ideally also the build system fixes (but I might end up having to bump that again, especially since the build system isn't really tied to a version of the mod so delaying releases for something that doesn't directly affect releases doesn't make too much sense).

My current thoughts on a gui like that are to make it as simple as possible -- probably just listing chunks that have been saved and when they were saved, without giving an actual map. There are two reasons for this: a) it'd be much simpler to write without writing a lot of complex minimap logic, and b) it'd be faster performance-wise since I think it's pretty trivial to get a list of saved chunks in a region while actually loading chunks is more intensive. Of course, I haven't actually tried implementing it yet, so I wouldn't know for sure. And it might be possible to render an overlay on top of existing minimaps too -- that's something else I'd want to look into.

A button that renders the map externally is also something that'd be nice to have; I've wanted to add some kind of toolchain system for quite some time but never got around to it. I'm not sure exactly what it would look like, though.

@Tsoccerguy3
Copy link

This feature is not really needed , add in the https://journeymap.info/Home mod .
Although you can use their API to make the calls internally , this is not needed if they player is in a Forge modded instance . The player can trigger a in game offline map of everything in the save file .It can be viewed in game or in browser . The player can put Minecraft and the browser side by side for even more convenience . There is also Voxel minimap for a in game map that can be viewed at anytime by pressing the keybind (M)

Pokechu22 added a commit that referenced this issue Feb 14, 2019
Right now I'm not doing anything, and without further refactoring of
state (as planned) this will probably be a significant memory leak since
I'm not keeping the data after downloading stops.  But it's the very
first step.
Pokechu22 added a commit that referenced this issue Feb 14, 2019
Currently only displays chunks that have already been saved, and nothing
is done with it yet.  I'll work on it further.  Also, most of the code
is copy-pasted from the chunk overrides GUI; I'll probably want to make
them share an abstract class or something.
Pokechu22 added a commit that referenced this issue Feb 14, 2019
createOrLoadRegionFile takes a chunk coordinate, not a region
coordinate.  I can probably optimize this a bit and just depend on the
region cache to load things properly for me instead of manually getting
region files, though repeatedly calling something like that seems
painful (and I still don't want to create empty files!)

Also, if the timestamp is 0, the chunk shouldn't be rendered since it
hasn't been saved (or someone magically time-traveled back to 1970 to
save it... which seems unlikely to me).

There's still a lot of additional work to be done on this.
@Pokechu22
Copy link
Owner

I've been doing some work on this (along with some other things). Here's my very early mockup:

2019-02-13_17 06 13

Color-coding is done by the time the chunk was saved (which vanilla does store!), currently fading green to "yellow" (I'm going to make it less ugly, I promise... I've been looking into HSL for other unrelated stuff too and it seems like the right thing to use here) over a day and yellow to red over a month. Those numbers aren't necessarily the most useful but worked well for testing on my very small map.

While other things exist that very adequately cover the actual minimap uses, I think that something for time is still useful and that's why I've been working on this (in addition to other miscellaneous cleanup).

@Pokechu22
Copy link
Owner

The GUI I mentioned earlier should be in the 1.14 release which will hopefully be out in a few hours. It's not completely done yet, but it's at least a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants