Skip to content

Commit

Permalink
✅ Comprehensive remainder round tests (#249)
Browse files Browse the repository at this point in the history
## What?
- Add and modify tests to remainder round

## Why?
- We were missing some if we compare it to the community tests. They should be mostly the same

## How?
- Comparing one file to the other and adding the ones that we were missing

## Testing?
- Run the whole remainder round test file

## Anything Else?
- We might be missing some logical paths, please check if you can come up with anything else
- Also fixed a bug in the async instantiator where creating a finished project was not waiting until the block advanced to the finished transition
  • Loading branch information
JuaniRios authored May 29, 2024
1 parent 915327e commit 720e9c6
Show file tree
Hide file tree
Showing 2 changed files with 715 additions and 276 deletions.
2 changes: 0 additions & 2 deletions pallets/funding/src/instantiator/async_features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ pub async fn async_create_evaluating_project<
let mut inst = instantiator.lock().await;

inst.start_evaluation(project_id, issuer).unwrap();
let now = inst.current_block();
project_id
}

Expand Down Expand Up @@ -791,7 +790,6 @@ pub async fn async_create_project_at<
block_orchestrator.add_awaiting_project(now + time_to_finish - time_to_evaluation, notify.clone()).await;
// Wait for the notification that our desired block was reached to continue
notify.notified().await;
let now = mutex_inst.lock().await.current_block();
async_create_evaluating_project(
mutex_inst.clone(),
test_project_params.metadata,
Expand Down
Loading

0 comments on commit 720e9c6

Please sign in to comment.