Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/plmc 138 rename runtimes #194

Merged
merged 13 commits into from
Mar 21, 2024
Merged

Feature/plmc 138 rename runtimes #194

merged 13 commits into from
Mar 21, 2024

Conversation

JuaniRios
Copy link
Contributor

What?

  • rename runtimes and node:
    • base -> polimec
    • testnet -> politest
    • polimec-parachain-node -> polimec-node
    • polimec-parachain-runtime -> politest-runtime
    • polimec-base-runtime -> polimec-runtime

Why?

  • "base" meant a template runtime with minimal pallets for using on the parachain auction and later upgrading to the real runtime. But now the base runtime is updated to be the latest live polimec runtime.
  • "testnet" could have remained with that name, but we might have a new testing network soon where we can have the testnet up, so a better name was convenient

How?

  • rename base declarations, do compilations and tests, and fix all errors that pop up

Testing?

integration-tests, pallet tests (with benches), release build

@JuaniRios JuaniRios self-assigned this Mar 18, 2024
lrazovic
lrazovic reviewed Mar 20, 2024
View reviewed changes
integration-tests/src/constants.rs Outdated Show resolved Hide resolved
nodes/parachain/src/command.rs Outdated Show resolved Hide resolved
nodes/parachain/src/command.rs Show resolved Hide resolved
nodes/parachain/src/chain_spec/polimec.rs Show resolved Hide resolved
@lrazovic lrazovic self-requested a review March 20, 2024 15:26
lrazovic
lrazovic approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits to complete the renaming and then we can proceed, probably some tweaks are also necessary in the README, justfile and few zombienet scripts.

JuaniRios and others added 5 commits March 20, 2024 16:48
@JuaniRios @lrazovic
Update integration-tests/src/constants.rs
ad6238e 
Co-authored-by: Leonardo Razovic <4128940+lrazovic@users.noreply.github.com>
@JuaniRios
renamings
f60d020
@JuaniRios
fmt
d52e720
@JuaniRios
merge possible corrupted
d72e285
@JuaniRios
fixes
7326f81
@JuaniRios JuaniRios requested a review from lrazovic March 21, 2024 11:33
@JuaniRios JuaniRios merged commit 0fb2ef3 into main Mar 21, 2024
@JuaniRios JuaniRios deleted the feature/plmc-138-rename-runtimes branch March 26, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 Awaiting requested review from vstam1

@lrazovic lrazovic Awaiting requested review from lrazovic

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic