-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Issuance and Dust fix #197
Conversation
// - https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polimec.org#/explorer/query/0x390d04247334df9d9eb02e1dc7c6d01910c950d99a5d8d17441eb202cd751f42 | ||
let _ = <Balances as tokens::fungible::Balanced<AccountId>>::deposit( | ||
&treasury_account, | ||
39988334 + 70094167, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could chose to do 100_000_000 * PLMC - total_issuance
instead of hard_coded values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of transparency, I opted to hard-code the two values, which will always be visible in the two linked DustLost
events. Obviously also 100_000_000 * PLMC - total_issuance
is correct, but I find it less clear in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Ran it locally and it was ok
What, Why and How?
DepositDust
: After the fix on the dust (Feat/send dust to treasury #193) we have to deposit the dust wrongly burned to the Blockchain Operation Treasury.UnhashedMigration
: At the TGE one account received a wrongVestingInfo
, we need to adress this.Testing
try-runtime
feature:cargo b -r -p polimec-base-runtime --features try-runtime