Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Issuance and Dust fix #197

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Migration: Issuance and Dust fix #197

merged 7 commits into from
Mar 19, 2024

Conversation

lrazovic
Copy link
Member

@lrazovic lrazovic commented Mar 19, 2024

What, Why and How?

  • DepositDust: After the fix on the dust (Feat/send dust to treasury #193) we have to deposit the dust wrongly burned to the Blockchain Operation Treasury.
  • UnhashedMigration: At the TGE one account received a wrong VestingInfo, we need to adress this.

Testing

  • Build the runtime with the try-runtime feature: cargo b -r -p polimec-base-runtime --features try-runtime
  • Execute the Try Runtime CLI:
try-runtime \
  --runtime target/release/wbuild/polimec-base-runtime/polimec_base_runtime.compact.compressed.wasm \
  on-runtime-upgrade \
  live --uri wss://rpc.polimec.org:443

@lrazovic lrazovic self-assigned this Mar 19, 2024
@lrazovic lrazovic changed the title Feat/issuance fix Migration: Issuance and Dust fix Mar 19, 2024
@lrazovic lrazovic marked this pull request as ready for review March 19, 2024 12:55
// - https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polimec.org#/explorer/query/0x390d04247334df9d9eb02e1dc7c6d01910c950d99a5d8d17441eb202cd751f42
let _ = <Balances as tokens::fungible::Balanced<AccountId>>::deposit(
&treasury_account,
39988334 + 70094167,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could chose to do 100_000_000 * PLMC - total_issuance instead of hard_coded values?

Copy link
Member Author

@lrazovic lrazovic Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of transparency, I opted to hard-code the two values, which will always be visible in the two linked DustLost events. Obviously also 100_000_000 * PLMC - total_issuance is correct, but I find it less clear in this case

@JuaniRios
Copy link
Contributor

CleanShot 2024-03-19 at 14 10 41@2x
Migration seems ok

Copy link
Contributor

@JuaniRios JuaniRios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Ran it locally and it was ok

@lrazovic lrazovic merged commit b910296 into main Mar 19, 2024
@JuaniRios JuaniRios deleted the feat/issuance-fix branch March 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants