Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/plmc-408-prevent-spam-on-project-creation #198

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Mar 19, 2024

What?

  • Prevent issuers from creating multiple projects that are seeking funding at the same time

Why?

  • Having a lot of garbage projects on chain will make it hard for the UI

How?

  • Flag the issuer DID once it creates a project, and this flag prevents further creations until the project reaches FundingFailed, EvaluationFailed, or FundingSuccessful

Testing?

  • issuer_cannot_have_multiple_active_projects()

Anything Else?

  • Found out that after Feature/plmc 442 delete remove from update store #180, projects that failed due to having no bids, where not being settled due to setting the status before calling do_end_funding()
    • New test written to prevent this bug again failed_auction_is_settled()

@JuaniRios JuaniRios marked this pull request as ready for review March 19, 2024 12:52
@JuaniRios JuaniRios requested a review from vstam1 March 19, 2024 12:52
@JuaniRios JuaniRios self-assigned this Mar 19, 2024
@JuaniRios JuaniRios requested a review from lrazovic March 19, 2024 12:52
pallets/funding/src/functions.rs Show resolved Hide resolved
…ation

# Conflicts:
#	pallets/funding/src/tests.rs
…ation

# Conflicts:
#	pallets/funding/src/lib.rs
@JuaniRios JuaniRios merged commit 6f58648 into main Mar 21, 2024
@JuaniRios JuaniRios deleted the feature/plmc-408-prevent-spam-on-project-creation branch March 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants