Feature/plmc 472 remove ct deposit fix bug with hold and reserve #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuaniRios
requested changes
Mar 20, 2024
lrazovic
approved these changes
Mar 20, 2024
JuaniRios
deleted the
feature/plmc-472-remove-ct-deposit-fix-bug-with-hold-and-reserve
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We are removing the ct deposit for the creation of the ct account in pallet_assets
Why?
As the ct token potentially has a bug where first the deposit could be held while to tokens are locked, but once we actually want to create the account, pallet assets requires a reserve, that does not work together with locked tokens. Upon reviewing the code, we came to the conclusion that we could completely remove the ct tokens and filter out all pallet calls to prevent spamming the chain with empty accounts.
How?
Remove all ct deposits
Testing?
Updated all tests
Screenshots (optional)
Anything Else?