Feat/refactor politest #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrazovic
commented
Mar 26, 2024
| @@ -20,12 +20,19 @@ | |||
| use std::{sync::Arc, time::Duration}; | |||
|
|
|||
| use cumulus_client_cli::CollatorOptions; | |||
| #[cfg(not(feature = "async-backing"))] | |||
| // Local Runtime Types | |||
| use polimec_runtime::{ | |||
There was a problem hiding this comment.
By default we use the polimec_runtime
| // Local Runtime Types | ||
| use polimec_runtime::{ | ||
| opaque::{Block, Hash}, | ||
| RuntimeApi, | ||
| }; | ||
|
|
||
| #[cfg(feature = "async-backing")] | ||
| use politest_runtime::{ |
There was a problem hiding this comment.
If we enable the async-backing feature we have to use the politest_runtime since it implements a RuntimeApi needed by the task_manager.
JuaniRios
approved these changes
Mar 26, 2024
Comment on lines
-323
to
438
| type ConsensusHook = cumulus_pallet_aura_ext::FixedVelocityConsensusHook< | ||
| Runtime, | ||
| RELAY_CHAIN_SLOT_DURATION_MILLIS, | ||
| BLOCK_PROCESSING_VELOCITY, | ||
| UNINCLUDED_SEGMENT_CAPACITY, | ||
| >; | ||
| #[cfg(feature = "async-backing")] | ||
| type CheckAssociatedRelayNumber = RelayNumberMonotonicallyIncreases; | ||
| type ConsensusHook = ConsensusHook; | ||
| type DmpQueue = frame_support::traits::EnqueueWithOrigin<MessageQueue, RelayOrigin>; |
There was a problem hiding this comment.
Add the extraction of ConensusHook into a separate type into polimec runtime too
runtimes/politest/src/lib.rs
Outdated
Comment on lines
792
to
797
| match asset { | ||
| AssetName::DOT => (AcceptedFundingAsset::DOT.to_assethub_id(), price), | ||
| AssetName::USDC => (AcceptedFundingAsset::USDC.to_assethub_id(), price), | ||
| AssetName::USDT => (AcceptedFundingAsset::USDT.to_assethub_id(), price), | ||
| AssetName::PLMC => (pallet_funding::PLMC_FOREIGN_ID, price), | ||
| } |
There was a problem hiding this comment.
We use hardcoded values in the polimec runtime. Add these changes there too
| [pallet_linear_release, LinearRelease] | ||
| ); | ||
| } | ||
|
|
||
| impl_runtime_apis! { | ||
| impl sp_consensus_aura::AuraApi<Block, AuraId> for Runtime { | ||
| fn slot_duration() -> sp_consensus_aura::SlotDuration { | ||
| sp_consensus_aura::SlotDuration::from_millis(Aura::slot_duration()) | ||
| sp_consensus_aura::SlotDuration::from_millis(parachains_common::SLOT_DURATION) |
There was a problem hiding this comment.
Just to be fully aligned with https://wiki.polkadot.network/docs/maintain-guides-async-backing#phase-1---update-parachain-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
politestruntime is now aligned with thepolimecone, with the following additions:async-backingfeature since Rococo has Asynchronous Backing enabled.Why?
We need a runtime available online so the frontend can test the pallet funding more easily.
Testing and Screenshots
The new
politestruntime is now running and producing blocks on Rococo.Anything Else?
I can recommend https://test.lastic.xyz/bulkcore1 to buy and assign a
Coreto a Para ID on Rococo!A Politest runtime is now running @ wss://beta.rolimec.org