Feat/millis timestamp #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstam1
reviewed
Mar 27, 2024
| [relaychain] | ||
| default_command = "polkadot" | ||
| default_command = "../polkadot-sdk/target/release/polkadot" |
There was a problem hiding this comment.
Could we add a bin folder that is ignored by git where we can personally add these binaries?
There was a problem hiding this comment.
Addressed and tested in 82f9d3f.
Should also the polimec-node point to the bin folder or should I leave it to ./target/release?
vstam1
approved these changes
Mar 27, 2024
JuaniRios
approved these changes
Apr 3, 2024
vstam1
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The timestamp pallet is storing the
nowas milliseconds, so we have to get the expiration from the JWT as milliseconds as well.