Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update errors #230

Merged
merged 7 commits into from
Apr 17, 2024
Merged

♻️ Update errors #230

merged 7 commits into from
Apr 17, 2024

Conversation

vstam1
Copy link
Collaborator

@vstam1 vstam1 commented Apr 12, 2024

What?

This Pr reworks the Error enum and updates all error related code for pallet funding.

Why?

To better structure all errors in Pallet funding.

How?

Most of the errors are structured into new collection of errors so that errors that are connected are part of the same error reason enum.

Testing?

✅ All tests should pass.

Screenshots (optional)

Anything Else?

Todo:

  • Merge main and fix merge conflicts.
  • Remove ValidityError and replace with MetadataError

@vstam1 vstam1 marked this pull request as ready for review April 12, 2024 12:02
@JuaniRios JuaniRios changed the title ⚡ Feature/update errors ⚡ Update errors Apr 15, 2024
@vstam1 vstam1 changed the title ⚡ Update errors ♻️ Update errors Apr 15, 2024
Copy link
Contributor

@JuaniRios JuaniRios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes, gg @vstam1

pallets/funding/src/lib.rs Outdated Show resolved Hide resolved
@vstam1 vstam1 merged commit 842d04f into main Apr 17, 2024
@vstam1 vstam1 deleted the feature/update_errors branch April 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants