Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/assets benchmarks #232

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Fix/assets benchmarks #232

merged 4 commits into from
Apr 12, 2024

Conversation

JuaniRios
Copy link
Contributor

What?

  • Fix pallet-assets benchmarks

Why?

  • We need to compute our runtime weights

How?

  • The create benchmark was trying to create an asset with id 0, and we used that for DOT. We know use 10 for DOT

Testing?

just dry-run-benchmarks

Anything Else?

When we set up prices for assets, we should refer to the id's not directly, but through the AcceptedFundingAsset.to_assethub_id() interface. Fixed that in mock

@JuaniRios JuaniRios self-assigned this Apr 12, 2024
@lrazovic lrazovic merged commit 53380e8 into main Apr 12, 2024
@lrazovic lrazovic deleted the fix/assets-benchmarks branch April 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants