Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧑‍💻 Restructure instantiator into modules #245

Merged
merged 1 commit into from
Apr 22, 2024
Merged

🧑‍💻 Restructure instantiator into modules #245

merged 1 commit into from
Apr 22, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 18, 2024 •
edited
Loading

What?

  • Move the instantiator code from a single file to multiple submodules

Why?

  • Was too big to read

How?

  • Separate into different files inside the instantiator module

Testing?

Normal tests to see if there's no compiler errors

@JuaniRios JuaniRios marked this pull request as ready for review April 18, 2024 10:04
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Apr 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Apr 18, 2024
Closed
@JuaniRios JuaniRios marked this pull request as draft April 18, 2024 10:09
@JuaniRios JuaniRios self-assigned this Apr 18, 2024
@JuaniRios JuaniRios force-pushed the 04-18-restructure_instantiator_into_modules branch 7 times, most recently from 0401d8f to afd86ba Compare April 18, 2024 10:48
@JuaniRios JuaniRios force-pushed the 04-18-restructure_instantiator_into_modules branch from afd86ba to 9f241ad Compare April 18, 2024 10:50
@JuaniRios JuaniRios marked this pull request as ready for review April 18, 2024 11:03
@JuaniRios JuaniRios changed the title Restructure instantiator into modules 🧑‍💻 Restructure instantiator into modules Apr 18, 2024
vstam1
vstam1 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change! Makes everything way easier to find and to read! Might be nice to add a readme shortly explaining what the Instantiator is. Especially now that we are a opensource project.

@JuaniRios JuaniRios merged commit c4ef266 into main Apr 22, 2024
@JuaniRios JuaniRios deleted the 04-18-restructure_instantiator_into_modules branch April 22, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1