Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 fix evaluation logic and benchmarks #254

Merged
merged 1 commit into from
Apr 23, 2024
Merged

🩹 fix evaluation logic and benchmarks #254

merged 1 commit into from
Apr 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 23, 2024 •
edited
Loading

What?

  • Fix evaluation logic and benchmarks
  • Add a test for this new logic

Why?

  • We changed the evaluation code and forgot to adapt some dependent code paths

How?

  • Evaluation benchmarks go from 2 -> 1. Since we removed in another PR the automatic unbending.
  • Add a check for the MaxEvaluationPerUser cap

Testing?

  • A new test called cannot_evaluate_more_than_user_limit

@JuaniRios Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios marked this pull request as ready for review April 23, 2024 09:43
@JuaniRios JuaniRios force-pushed the 04-23-_fix_evaluation_logic_and_benchmarks branch from d576bf9 to f6abd2d Compare April 23, 2024 09:47
@lrazovic lrazovic self-requested a review April 23, 2024 10:56
@lrazovic lrazovic assigned JuaniRios and unassigned lrazovic and vstam1 Apr 23, 2024
@JuaniRios JuaniRios merged commit 0f22f1b into main Apr 23, 2024
@JuaniRios JuaniRios deleted the 04-23-_fix_evaluation_logic_and_benchmarks branch April 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstam1 vstam1 vstam1 approved these changes

@lrazovic lrazovic lrazovic approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1